Skip to content

UHF-10374: Change the color-silver-light to color-black-5#1171

Merged
teroelonen merged 3 commits intomainfrom
UHF-10374
Feb 4, 2025
Merged

UHF-10374: Change the color-silver-light to color-black-5#1171
teroelonen merged 3 commits intomainfrom
UHF-10374

Conversation

@teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 31, 2025

UHF-10374

What was done

  • Removed unused styles referring to class .news-listing--teasers
  • Updated all instances of color-silver-light to color-black-5.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10374
  • Run make drush-cr

How to test

  • All the elements that use color-silver-light (#f7f7f8) as background color should now be changed to use the color-black-5 instead. This includes but is not limited to:
  • announcements
  • Early childhood education fee calculator
  • header search
  • table of contents
  • mobile menu
  • unit contact information block on the unit page
  • content cards paragraph
  • hearings paragraph
  • ploughing schedule
  • popular services
  • react searches
  • service list search
  • target group links
  • unit contact card
  • unit search

I don't think its required to test all of these elements but check some and check the code.

  • I checked all the items and flagged announcements and job search for design that after this change the contrast on those elements and their other parts are a bit weak. They will be resolved on a different ticket.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

Copy link
Contributor

@annadruid annadruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@khalima khalima added the install-drupal-from-scratch Select this to install Drupal from scratch in visual regression tests label Feb 4, 2025
@github-actions
Copy link

github-actions bot commented Feb 4, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1171/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

install-drupal-from-scratch Select this to install Drupal from scratch in visual regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants